-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix Dropdown change event when allow_custom_value is true #12572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/f0b8204b7c64de00f08fa144504b8183fd7a6a7e/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@f0b8204b7c64de00f08fa144504b8183fd7a6a7e#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/f0b8204b7c64de00f08fa144504b8183fd7a6a7e/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
✅ Changeset approved by @freddyaboulton
|
| import { | ||
| type SelectData, | ||
| type KeyUpData, | ||
| type CustomButton as CustomButtonType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jw why this is preferred?
|
Seeing a small issue where the clicking outside does not trigger the Screen.Recording.2025-12-17.at.10.47.43.AM.movNotice that when I backspace to get back to "hello" and then click outside the dropdown, it does not change the output textbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @freddyaboulton !
Noticed that there's a mismatch in padding in input and dropdown boxes that's kind of annoying:

|
Thanks for the reviews @aliabid94 @abidlabs ! Just pushed up a fix for that issue @abidlabs . @aliabid94 I think that's expected because in the demo I added the output component is a textbox not a dropdown. If both input and output components are dropdowns they are aligned
|
|
Merging thank you @aliabid94 @abidlabs ! |

Description
Closes: #12548
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh