-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Use a slower check rate on windows, otherwise windows locks up #12556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/599241021a607067722d1e01d370560a6982d495/gradio-6.1.0-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@599241021a607067722d1e01d370560a6982d495#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/599241021a607067722d1e01d370560a6982d495/gradio-client-2.0.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
✅ Changeset approved by @freddyaboulton
|
abidlabs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow I wouldn't have expected that but Windows 🤷. LGTM since although I can't test it, this is the only major change to the queue that we (I) made. Thanks for the fix @freddyaboulton!
|
i just tested this https://gradio-pypi-previews.s3.amazonaws.com/dff7e77e5a072a3c8b0832c248962a2708cb1adb/gradio-6.1.0-py3-none-any.whl sadly didnt fix if there is some debug parameter i can set i can try and give you feedback |
|
yea it's bizzarro Thanks for reviewing! |
| self.sleep_when_free = 0.001 | ||
| self.progress_update_sleep_when_free = 0.01 | ||
| self.sleep_when_free = 0.05 if platform.system() == "Windows" else 0.001 | ||
| self.progress_update_sleep_when_free = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw previously this was:
self.progress_update_sleep_when_free = 0.1
this one failed |
|
Thanks for checking @FurkanGozukara - can you please try with this one? |
|
yes this worked on one of the 1 apps that was broken. works same as 5.5.0 i am using python 3.10.11 excellent work thank you @freddyaboulton |
|
Thank you for checking @FurkanGozukara ! |
|
@freddyaboulton thank you so much. when can we expect this in release? 6.1.1? |


Description
Closes: #12521
Closes: #12492
Before
After
Testing with this demo
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh