Video accessibility #12260
Open
Video accessibility #12260
+38
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accessibility and user interaction. Replace progress element with input range for better control over playback time.
Collaborator
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
@hannahblair can you take a look at this when you get a chance?
hannahblair
reviewed
Dec 9, 2025
| time = (duration * (clientX - left)) / (right - left); | ||
| } | ||
| function handle_slider_input(event: Event): void { |
Collaborator
There was a problem hiding this comment.
i think this might be redundant now
hannahblair
reviewed
Dec 9, 2025
| let video: HTMLVideoElement; | ||
| let processingVideo = false; | ||
| function handleMove(e: TouchEvent | MouseEvent): void { |
Collaborator
There was a problem hiding this comment.
do we need to remove this now?
hannahblair
reviewed
Dec 9, 2025
| } | ||
| } | ||
| function handle_click(e: MouseEvent): void { |
Collaborator
There was a problem hiding this comment.
i dont think this is used anymore either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement slider input for video progress in Player.svelte, enhancing accessibility and user interaction. Replace progress element with input range for better control over playback time.
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh