[newchem-cpp] more clang-tidy checks #466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transcribed function is called step_rate_gauss_seidel to mirror the naming convention of `step_rate_newton_raphson`. I explicitly disabled clang-format to make it easier for us to factor out common logic that is shared with `species_density_derivatives_0d` - In slightly more detail, the logic is similar enough that we could definitely factor out a lot of common logic. - The important thing is that we don't want the logic in each function to evolve independently
…_step_rate_gauss_seidel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be reviewed after #425 is merged.
This adds some new clang-tidy checks, and makes some fixes. It highlighted a few cases that we don't really care about (but its promising for looking at future code)