adjust pygrackle/utilities/testing.py to satisfy flake8 #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabruzzo
added
gracklepy
Contributor
|
Looks like we're still using |
mabruzzo
added a commit
to mabruzzo/grackle
that referenced
this pull request
Aug 20, 2025
Background ---------- Previously we had replaced 99% uses of the Flake8 linter with the Ruff linter (not to be confused with the Ruff formatter). We had continued to use the Flake8 linter to deal with the following 2 files: 1. **gracklepy/utilities/testing.py** 2. **gracklepy/__init__.py** In more detail, we were suppressing certain warnings in these 2 files from Flake8, and transistioning to using the Ruff formatter for these files would involve making a few changes. More recently PRs grackle-project#368 and grackle-project#369 introduced the required changes into the main branch. Now that those changes have been ported to the newchem-cpp branch, we are able to make this change. What Changed ------------ I essentially changed 3 things: 1. We no longer install and use flake8 in the continuous integration 2. I removed the **setup.cfg** file (it was **only** being used to track flake8 configuration information 3. I needed to tweak **pyproject.toml** to both: - stop excluding the **gracklepy/utilities/testing.py** and **gracklepy/__init__.py** files from the linter - stop listing flake8 as a development dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.