address a bug calc_temp_cloudy_g.F #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's **important** that we introduce this commit **before** we bump the gold-standard
brittonsmith
approved these changes
Jul 30, 2025
mabruzzo
added a commit
to mabruzzo/grackle
that referenced
this pull request
Aug 20, 2025
…2024transcribe/calc_temp_cloudy_g I needed to introduce the bugfix from PR grackle-project#367.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #366. This change requires a gold-standard bump.
EDIT: There was a minor bug with the way that test_get_grackle_version.py handled tags starting with
gold-standard-v*. I back-ported a fix that I had previously applied to thenewchem-cppbranch.EDIT2: I had to reorder commits (and alter the commit associated with the "gold-standard-v4") so that the fix to test_get_grackle_version.py is actually present when we check out "gold-standard-v4"