Skip to content

Conversation

@mabruzzo
Copy link
Collaborator

@mabruzzo mabruzzo commented Jun 7, 2025

This commit merges an extremely simplistic .pre-commit-config.yaml file that applies some extremely simplistic checks. The intention to merge this commit into the main branch while we configure pre-commit to run code formatting/linting in the newchem-cpp branch. PR #287 (where we start configuring pre-commit to run formatting/linting) is configured so all changes build off this commit (in other words, there won't be any merge conflicts when we ultimately merge newchem-cpp into main).

If we don't merge a .pre-commit-config.yaml file into the main branch, then pre-commit.ci will report a failure (since it can't find a .pre-commit-config.yaml file)

In slightly more detail, the file configures pre-commit to check that

  • executable files have shebangs
  • filenames won't cause issues on case-insensitive file systems (e.g. some file systems can't differentiate myfile.c and MyFile.c)
  • our .toml, .json, .yaml files all use valid syntax

The intention here is to merge this commit into the main branch while we
configure pre-commit to run code formatting/linting in the newchem-cpp
branch. PR grackle-project#287 (where we start configuring pre-commit to run
formatting/linting) is configured so all changes build off this commit
(in other words, there won't be any merge conflicts when we ultimately
merge newchem-cpp into main).

If we don't merge a .pre-commit-config.yaml file into the main branch,
then pre-commit.ci will report a failure (since it can't find a
.pre-commit-config.yaml file)
@brittonsmith brittonsmith merged commit bfe0476 into grackle-project:main Jun 9, 2025
4 checks passed
@mabruzzo mabruzzo deleted the dummy-precommit branch June 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants