Support running subset of pygrackle test without a an editable install #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, our test suite would fail unless we had an editable install. In reality, all test-cases outside of test_models infer the location of the data files based on the location of the test-files, which are never part of the wheel.[^1] Therefore, this PR introduces a few small tweaks to support testing all test-cases outside of test_models. Overall, this will be really useful for providing a more rigorous check of the correctness of our precompiled wheels (see PR grackle-project#320). [^1]: I know that some packages do ship their test-suites as part of the wheel, but that currently makes absolutely no sense for us unless we provide users with an easy way to get the datafiles. We can always revisit this choice in the future after we merge PRs grackle-project#235 & grackle-project#237 (or come up with an equivalent)
mabruzzo
added
trivial
testing
mabruzzo
added a commit
to mabruzzo/grackle
that referenced
this pull request
May 19, 2025
(We can enable this now that we rebased this branch to include the changes from PR grackle-project#335)
brittonsmith
approved these changes
May 22, 2025
mabruzzo
added a commit
to mabruzzo/grackle
that referenced
this pull request
May 30, 2025
(We can enable this now that we rebased this branch to include the changes from PR grackle-project#335)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, our test suite would fail unless we had an editable install. In reality, all test-cases outside of test_models infer the location of the data files based on the location of the test-files, which are never part of the wheel.1 Therefore, this PR introduces a few small tweaks to support testing all test-cases outside of test_models.
Overall, this will be really useful for providing a more rigorous check of the correctness of our precompiled wheels (see PR #320).
Footnotes
I know that some packages do ship their test-suites as part of the wheel, but that currently makes absolutely no sense for us unless we provide users with an easy way to get the datafiles. We can always revisit this choice in the future after we merge PRs Auto File Management Part 1: Introducing a Datafile Management Tool #235 & Auto File Management Part 2: Allow Grackle to search for automatically managed data files #237 (or come up with an equivalent) ↩