Skip to content

[CRITICAL BUGFIX] Fix a significant oversight in **GrackleConfig.cmake** #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brittonsmith merged 1 commit into from
May 19, 2025
Merged

[CRITICAL BUGFIX] Fix a significant oversight in **GrackleConfig.cmake** #330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cmake/GrackleConfig.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,14 @@ endmacro()
# STEP 0: PREAMBLE
# ----------------

# We use if(...IN_LIST...), make sure it is available
# this file uses `if(...IN_LIST...)`, which was introduced in CMake 3.3
# -> important: the `cmake_minimum_required` command is not the right tool for
# enforcing this (e.g. calling `cmake_minimum_required(VERSION 3.3)` will
# call versions of CMake with version >= 4.0 to abort
if(CMAKE_VERSION VERSION_LESS 3.3)
_FIND_GRACKLE_FAIL("Grackle requires CMake 3.3 or later")
endif()

cmake_minimum_required(VERSION 3.3)

# store options directly taken from the build
set(_GRACKLEBUILD_USE_DOUBLE @GRACKLE_USE_DOUBLE@)
set(_GRACKLEBUILD_USE_OPENMP @GRACKLE_USE_OPENMP@)
Expand Down