Skip to content

fix: openapi revamp: return error to LLM if args are invalid JSON #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

fix: openapi revamp: return error to LLM if args are invalid JSON #843

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e89e05
fix: openapi revamp: return error to LLM if args are invalid JSON
g-linville Sep 6, 2024
590d6ef
Update pkg/openapi/run.go
g-linville Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/openapi/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ func Run(operationID, defaultHost, args string, t *openapi3.T, envs []string) (s
// Validate args against the schema.
validationResult, err := gojsonschema.Validate(gojsonschema.NewStringLoader(schemaJSON), gojsonschema.NewStringLoader(args))
if err != nil {
return "", false, err
// We don't return an error here because we want the LLM to be able to maintain control and try again.
return "ERROR: failed to validate arguments. Make sure your arguments are valid JSON.", false, nil
}

if !validationResult.Valid() {
Expand Down