Skip to content

fix: normalize LLM-hallucinated tool names #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: normalize LLM-hallucinated tool names #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/engine/engine.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ func (e *Engine) complete(ctx context.Context, state *State) (*Return, error) {
}
if toolID == "" {
log.Debugf("failed to find tool id for tool %s in tool_call result", content.ToolCall.Function.Name)
toolID = content.ToolCall.Function.Name
toolID = types.ToolNormalizer(content.ToolCall.Function.Name)
missing = true
}
state.Pending[content.ToolCall.ID] = *content.ToolCall
Expand Down
2 changes: 1 addition & 1 deletion pkg/tests/runner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,7 +954,7 @@ func TestMissingTool(t *testing.T) {

r.RespondWith(tester.Result{
Func: types.CompletionFunctionCall{
Name: "not bob",
Name: "not.bob",
},
})

Expand Down
2 changes: 1 addition & 1 deletion pkg/tests/testdata/TestMissingTool/call1-resp.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"toolCall": {
"id": "call_1",
"function": {
"name": "not bob"
"name": "not.bob"
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions pkg/tests/testdata/TestMissingTool/call2.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"toolCall": {
"id": "call_1",
"function": {
"name": "not bob"
"name": "not.bob"
}
}
}
Expand All @@ -46,13 +46,13 @@
"role": "tool",
"content": [
{
"text": "ERROR: can not call unknown tool named [not bob]"
"text": "ERROR: can not call unknown tool named [notBob]"
}
],
"toolCall": {
"id": "call_1",
"function": {
"name": "not bob"
"name": "not.bob"
}
},
"usage": {}
Expand Down