Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 18, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Go Version Update
  • Dependency Update

Description

Use http.ResponseController to hijack the connection.

Related Tickets & Documents

Added/updated tests?

  • Yes
  • No, and this is why: covered by existing tests
  • I need help with writing tests

Run verifications and test

  • make verify is passing
  • make test is passing

@ghost ghost mentioned this pull request Jun 18, 2024
1 task
@ghost ghost changed the title use http.ResposnseController Use http.ResponseController Jun 19, 2024
Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaitaiwan jaitaiwan merged commit 7e5e9b5 into gorilla:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants