Use req.URL.EscapedPath() instead of getPath(req)

[mikelikesbikes]

This change drops support of go < 1.5. go1.4 has been officially unsupported since go1.6 was released 2016/02/17.

The PR was motivated by a bug I discovered, where req.RequestURI was returning "", so my router was failing to route on the escaped path.

Very open to thoughts and/feedback on how to proceed. Thanks!

[elithrar]

I am OK with this, and this makes more sense than the other PR. 1.5 has been around for a long while.

…

On Tue, Oct 17, 2017 at 10:37 PM Mike Busch ***@***.***> wrote: This change drops support of go < 1.5. go1.4 has been officially unsupported <https://golang.org/doc/devel/release.html#policy> since go1.6 was released 2016/02/17. The PR was motivated by a bug I discovered, where req.RequestURI was returning "", so my router was failing to route on the escaped path. Very open to thoughts and/feedback on how to proceed. Thanks! ------------------------------ You can view, comment on, or merge this pull request online at: #306 Commit Summary - use req.URL.EscapedPath() instead of getPath(req) File Changes - *M* mux.go <https://github.com/gorilla/mux/pull/306/files#diff-0> (25) - *M* regexp.go <https://github.com/gorilla/mux/pull/306/files#diff-1> (6) Patch Links: - https://github.com/gorilla/mux/pull/306.patch - https://github.com/gorilla/mux/pull/306.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#306>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABIcLbYkeXV5VmuwpF2TwqtYRUhSk8iks5stQ_8gaJpZM4P8yMy> .

[kisielk]

Agreed

…

On Oct 17, 2017, at 19:32, Matt Silverlock ***@***.***> wrote: I am OK with this, and this makes more sense than the other PR. 1.5 has been around for a long while. On Tue, Oct 17, 2017 at 10:37 PM Mike Busch ***@***.***> wrote: > This change drops support of go < 1.5. go1.4 has been officially > unsupported <https://golang.org/doc/devel/release.html#policy> since > go1.6 was released 2016/02/17. > > The PR was motivated by a bug I discovered, where req.RequestURI was > returning "", so my router was failing to route on the escaped path. > > Very open to thoughts and/feedback on how to proceed. Thanks! > ------------------------------ > You can view, comment on, or merge this pull request online at: > > #306 > Commit Summary > > - use req.URL.EscapedPath() instead of getPath(req) > > File Changes > > - *M* mux.go <https://github.com/gorilla/mux/pull/306/files#diff-0> > (25) > - *M* regexp.go <https://github.com/gorilla/mux/pull/306/files#diff-1> > (6) > > Patch Links: > > - https://github.com/gorilla/mux/pull/306.patch > - https://github.com/gorilla/mux/pull/306.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#306>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/AABIcLbYkeXV5VmuwpF2TwqtYRUhSk8iks5stQ_8gaJpZM4P8yMy> > . > — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.