Skip to content

Conversation

@ryanbr
Copy link
Contributor

@ryanbr ryanbr commented Apr 4, 2025

@ryanbr
Copy link
Contributor Author

ryanbr commented Apr 14, 2025

@gorhill looks okay?

@gorhill
Copy link
Owner

gorhill commented Apr 14, 2025

I am not worried about @actions/checkout, unlike some more obscure actions, and pinning to a specific version is a double edge solution: security fixes past the pinned version would be left out. I prefer to keep the current workflow as is.

@ryanbr
Copy link
Contributor Author

ryanbr commented Apr 15, 2025

@thypon thoughts? ^

@ryanbr
Copy link
Contributor Author

ryanbr commented Apr 19, 2025

Quoted from @thypon;

  • I agree that action/checkout is a minor. softprops/action-gh-release is not an official github action, and is vulnerable to supply chain attacks as much as tj-actions in this case.
  • Moreover renovate is able to manage these updates with the following config.
{
  "extends": [
      "config:recommended",
      "helpers:pinGitHubActionDigestsToSemver",
      ":pinDevDependencies"
  ]
}

This will:

  • shield against the most supply chain attacks
  • make the supply chain reproducible, and not break at these behind the scene bumps

@gorhill
Copy link
Owner

gorhill commented Apr 19, 2025

Ok, so if you can revert the changes to actions/checkout@v4, I will pull the changes for softprops/action-gh-release@v2.

@ryanbr
Copy link
Contributor Author

ryanbr commented Apr 27, 2025

Done @gorhill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants