Release v1.11.11 #2586
Release v1.11.11 #2586
Conversation
- Remove duplicate `aspect-ratio` from `iframe-container` in `ProjectRunner.vue` and apply it to fullscreen mode in `ProjectRunnerSurface.vue` instead Fixes #2565 Signed-off-by: Aofei Sheng <[email protected]>
Bumps the go-modules group with 1 update in the /tools/ai directory: [github.com/goplus/spx/v2](https://github.com/goplus/spx). Updates `github.com/goplus/spx/v2` from 2.0.0-pre.36 to 2.0.0-pre.37 - [Release notes](https://github.com/goplus/spx/releases) - [Commits](goplus/spx@v2.0.0-pre.36...v2.0.0-pre.37) --- updated-dependencies: - dependency-name: github.com/goplus/spx/v2 dependency-version: 2.0.0-pre.37 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-modules ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(spx-gui): enhance UIButton with style, shape, and type * feat(spx-gui): adjust style for issue #2532 * refactor(spx-gui): add `size` prop to sound player components * feat(spx-gui): update UICheck style * refactor(spx-gui): consolidating button styles and usage * refactor(spx-gui): remove UIFlatButton, UIIconButton and UITagButton * refactor(spx-gui): add white button type to UIButton * refactor(spx-gui): introduce CSS variables for UIButton * style(spx-gui): update UIButton props * refactor(spx-gui): move ui-design/index.vue to docs/ui-design.vue
* style(spx-gui): refine UINumberInput prefixes * style(spx-gui): refine UITextInput prefixes
* Initial plan * Update spx version to v2.0.0-pre.38 and rebuild assets Co-authored-by: nighca <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: nighca <[email protected]>
Summary of ChangesHello @nighca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request constitutes a release update, primarily focusing on a major refactoring of the UI button components to enhance flexibility and consistency across the application. It also includes an update to the underlying SPX version and introduces a dedicated documentation page for the new button design. These changes aim to streamline UI development and improve the overall user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request appears to be for Release v1.11.11. The core of the changes is a significant and well-executed refactoring of the UI button components. The UIButton component has been enhanced with variant, shape, and color properties, replacing the older type property. This change has allowed for the consolidation of button styles, leading to the removal of UIFlatButton and UIIconButton. These changes have been applied consistently throughout the codebase.
Other notable changes include:
- Bumping the
spxversion to2.0.0-pre.38. - Improvements to
SoundPlayerto support different sizes. - A new documentation page for UI design has been added to showcase the new components.
- Minor style and consistency improvements across various components.
The refactoring improves the component architecture and maintainability. I have one suggestion regarding the use of inline styles for a button, which could be addressed by extending the new UIButton component.
Related project: https://github.com/orgs/goplus/projects/6/views/1