Skip to content

fix: auto-install binary on run if missing#654

Merged
jpoehnelt merged 2 commits intomainfrom
fix/pnpm-binary
Mar 31, 2026
Merged

fix: auto-install binary on run if missing#654
jpoehnelt merged 2 commits intomainfrom
fix/pnpm-binary

Conversation

@jpoehnelt
Copy link
Copy Markdown
Member

pnpm skips postinstall when the package is already cached/up-to-date. This ensures run.js will auto-trigger install.js if the binary is missing, fixing the 'gws binary not found' error.

pnpm skips postinstall when the package is already cached/installed.
This commit ensures run.js will auto-trigger install.js if the
binary is missing, fixing the 'gws binary not found' error.
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 31, 2026

🦋 Changeset detected

Latest commit: 15fb583

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googleworkspace-bot googleworkspace-bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the gws binary might be missing due to pnpm's optimization of skipping postinstall scripts. By modifying the execution flow to verify the existence of the binary at runtime and triggering the installation script if necessary, the package ensures that the environment is correctly configured before attempting to run the command.

Highlights

  • Automatic Binary Installation: Updated run.js to automatically trigger the installation script if the gws binary is missing, ensuring functionality even when pnpm skips postinstall hooks.
  • Improved Error Handling: Replaced the hard exit with a synchronous installation process that inherits stdio, providing a better user experience when the binary is not found.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Generative AI Prohibited Use Policy, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an auto-install mechanism in run.js to automatically run install.js if the required binary is missing, which addresses issues where pnpm skips the post-install step. The review feedback suggests improving the robustness of this feature by explicitly checking for and logging errors if the auto-install process fails to start, ensuring consistency with existing error handling.

@github-actions github-actions bot added the gemini: reviewed Gemini Code Assist has reviewed the latest changes label Mar 31, 2026
@jpoehnelt jpoehnelt merged commit 6ccbb42 into main Mar 31, 2026
30 checks passed
@jpoehnelt jpoehnelt deleted the fix/pnpm-binary branch March 31, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. gemini: reviewed Gemini Code Assist has reviewed the latest changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants