fix: auto-install binary on run if missing#654
Conversation
pnpm skips postinstall when the package is already cached/installed. This commit ensures run.js will auto-trigger install.js if the binary is missing, fixing the 'gws binary not found' error.
🦋 Changeset detectedLatest commit: 15fb583 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the gws binary might be missing due to pnpm's optimization of skipping postinstall scripts. By modifying the execution flow to verify the existence of the binary at runtime and triggering the installation script if necessary, the package ensures that the environment is correctly configured before attempting to run the command. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an auto-install mechanism in run.js to automatically run install.js if the required binary is missing, which addresses issues where pnpm skips the post-install step. The review feedback suggests improving the robustness of this feature by explicitly checking for and logging errors if the auto-install process fails to start, ensuring consistency with existing error handling.
pnpm skips
postinstallwhen the package is already cached/up-to-date. This ensuresrun.jswill auto-triggerinstall.jsif the binary is missing, fixing the 'gws binary not found' error.