Skip to content

Conversation

eegli
Copy link
Contributor

@eegli eegli commented Feb 3, 2022

Mocks registry as discussed in the issue linked below. Plus updated copyright notes.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #191 🦕

@eegli eegli changed the title Feat mocks registry WIP / mocks registry Feb 3, 2022
@eegli eegli changed the title WIP / mocks registry feat: implement mocks registry Feb 3, 2022
Copy link
Contributor

@jpoehnelt jpoehnelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay in reviewing this!

@jpoehnelt jpoehnelt merged commit 40db691 into googlemaps:main Feb 10, 2022
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
## [2.4.0](v2.3.1...v2.4.0) (2022-02-10)

### Features

* implement mocks registry ([#194](#194)) ([40db691](40db691))

### Miscellaneous Chores

* **deps-dev:** bump @types/google.maps from 3.47.3 to 3.47.4 ([#199](#199)) ([f9b10c2](f9b10c2))
* **deps-dev:** bump eslint-plugin-jest from 26.0.0 to 26.1.0 ([#195](#195)) ([01eb98d](01eb98d))
* **deps-dev:** bump jest from 27.4.7 to 27.5.0 ([#196](#196)) ([9294404](9294404))
* **deps-dev:** bump jest from 27.5.0 to 27.5.1 ([#198](#198)) ([deb25fc](deb25fc))
* **deps-dev:** bump rollup from 2.67.0 to 2.67.1 ([#197](#197)) ([fc9fa45](fc9fa45))
@github-actions
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eegli eegli deleted the feat--mocks-registry branch February 11, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Type-safe mocks registry
2 participants