Skip to content

Conversation

eegli
Copy link
Contributor

@eegli eegli commented Jan 2, 2022

This PR mainly proposes a change in the project structure as discussed in #163.

Also:

  • Fixed a lot of linter errors related to class member accessibility and others
  • Added the correct signatures to some mock implementations that were missing it

Quite a big PR. Let me know if something should be adjusted. Cheers!


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #163 🦕

@eegli eegli changed the title Feat/street view mocks feat: street view mocks and project structure Jan 2, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #167 (bde4530) into main (a36400a) will increase coverage by 5.87%.
The diff coverage is 52.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   43.17%   49.04%   +5.87%     
==========================================
  Files          18       24       +6     
  Lines         410      522     +112     
  Branches        2        2              
==========================================
+ Hits          177      256      +79     
- Misses        233      266      +33     
Impacted Files Coverage Δ
src/drawing/DOM/mappanes.ts 100.00% <ø> (ø)
src/maps/coordinates/point.ts 12.50% <0.00%> (ø)
src/maps/coordinates/size.ts 62.50% <ø> (ø)
src/maps/event/mvcarray.ts 12.50% <0.00%> (ø)
src/drawing/marker/marker.ts 5.08% <5.71%> (ø)
src/drawing/polygons/polyline.ts 8.69% <5.88%> (ø)
src/drawing/DOM/overlayview.ts 31.25% <22.22%> (ø)
src/maps/coordinates/latlng.ts 23.07% <24.00%> (ø)
src/drawing/data/data.ts 43.07% <26.66%> (ø)
src/drawing/DOM/mapcanvasprojection.ts 31.25% <31.25%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36400a...bde4530. Read the comment docs.

@jpoehnelt jpoehnelt merged commit f2c9a96 into googlemaps:main Jan 4, 2022
@jpoehnelt
Copy link
Contributor

Thanks!!!!

github-actions bot pushed a commit that referenced this pull request Jan 4, 2022
BREAKING CHANGE: change to project structure f2c9a96
github-actions bot pushed a commit that referenced this pull request Jan 4, 2022
## [2.0.0](v1.5.1...v2.0.0) (2022-01-04)

### ⚠ BREAKING CHANGES

* change to project structure

### Features

* street view mocks and project structure ([#167](#167)) ([f2c9a96](f2c9a96))

### Miscellaneous Chores

* **deps-dev:** bump @types/jest from 27.0.3 to 27.4.0 ([#166](#166)) ([a36400a](a36400a))
* **deps-dev:** bump eslint-plugin-jest from 25.3.0 to 25.3.2 ([#164](#164)) ([e8adbf9](e8adbf9))
* **deps-dev:** bump eslint-plugin-jest from 25.3.2 to 25.3.3 ([#165](#165)) ([82adaee](82adaee))
* **deps-dev:** bump eslint-plugin-jest from 25.3.3 to 25.3.4 ([#168](#168)) ([2191cbb](2191cbb))
* **deps-dev:** bump rollup from 2.61.1 to 2.62.0 ([#162](#162)) ([b182544](b182544))
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jpoehnelt
Copy link
Contributor

@eegli I would like to nominate you for https://opensource.google/docs/growing/peer-bonus/, but need an email address. Please send to me at [email protected].

@eegli
Copy link
Contributor Author

eegli commented Jan 4, 2022

@jpoehnelt thank you very much! Sent you a mail.

@eegli eegli deleted the feat/street-view-mocks branch January 4, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project structure and street view mocks
2 participants