Update Basic Autocomplete to use gmp-map #701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
chrisjshull
reviewed
Aug 12, 2025
chrisjshull
reviewed
Aug 13, 2025
ejhaselden
force-pushed
the
basic-autocomplete-update
branch
from
810aeb3 to
41346d0
Compare
ejhaselden
force-pushed
the
basic-autocomplete-update
branch
from
41346d0 to
5d96c14
Compare
chrisjshull
reviewed
Aug 19, 2025
| )) as google.maps.MapsLibrary; | ||
|
|
||
| // Get the initial center directly from the gmp-map element's property. | ||
| const center = gmpMapElement.center; | ||
|
|
||
| // Set the initial location bias for the autocomplete element. | ||
| placeAutocompleteElement.locationBias = center; | ||
|
|
||
| // Create the map object with specified options. |
| const mapDiv = document.getElementById('map-container') as HTMLElement; | ||
| const center: google.maps.LatLngLiteral = { lat: 40.749933, lng: -73.98633 }; // New York City | ||
|
|
||
| const gmpMapElement = document.querySelector('gmp-map') as any; |
There was a problem hiding this comment.
s/any/google.maps.MapElement/
ditto others (generally, let's try to avoid any)
| const advancedMarkerElement: google.maps.marker.AdvancedMarkerElement = new AdvancedMarkerElement({ | ||
| map: map, | ||
| }); | ||
| const advancedMarkerElement: google.maps.marker.AdvancedMarkerElement = |
There was a problem hiding this comment.
one the anys are gone above, I think you can strip out all the : type type decls?
| <gmp-place-details-compact orientation="horizontal"> | ||
| <gmp-place-details-compact | ||
| orientation="horizontal" | ||
| style="width: 400px; |
There was a problem hiding this comment.
might be good to comment why inline styles are being used here (esp noting because this element will be moving inside the DOM once JS loads).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.