chore: move the attemptFailed logic from BaseApiTracer to ApiTracer
#3037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomarquezp
added
the
do not merge
diegomarquezp
changed the title
attemptFailed overload logic from BaseApiTracer to ApiTracer
diegomarquezp
changed the title
attemptFailed overload logic from BaseApiTracer to ApiTracerattemptFailed logic from BaseApiTracer to ApiTracer
lqiu96
reviewed
Jul 9, 2024
| @@ -121,7 +123,10 @@ default Scope inScope() { | |||
| * @param error the transient error that caused the attempt to fail. | |||
| * @param delay the amount of time to wait before the next attempt will start. | |||
| */ | |||
| default void attemptFailedDuration(Throwable error, java.time.Duration delay) {}; | |||
| default void attemptFailedDuration(Throwable error, java.time.Duration delay) { | |||
| // defaults to do the same as attemptFailed(Throwable, org.threeten.bp.Duration) | |||
There was a problem hiding this comment.
nit: Can you add a blurb to reflect the why?
i.e. Customers may have older/legacy code that directly implements ApiTracer's attemptFailed() method and their overriden logic should be invoked in gax.
There was a problem hiding this comment.
Good suggestion, thank you. I added a similar blurb in the body comment.
|
|
lqiu96
approved these changes
Jul 9, 2024
blakeli0
removed
the
do not merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3016
On
bigtableandspanner:Thanks @blakeli0 and @lqiu96 for the directions.