chore: Implement LazyValue helper#45
Merged
Merged
Conversation
This was referenced Oct 26, 2023
bajajneha27
approved these changes
Oct 26, 2023
| # configurable, as is the retry "interval", i.e. the time since the last | ||
| # failure before an access will retry the computation. | ||
| # | ||
| # A computation can cause its result (or error) to expire after a |
There was a problem hiding this comment.
What's the default expiration that we're setting for cache expiry?
Contributor
Author
There was a problem hiding this comment.
By default, memoized values never expire. I'll make that more explicit in the documentation.
| # @raise [Exception] if a fatal error happened, or retries have been | ||
| # exhausted. | ||
| # | ||
| def await *extra_args, transient_errors: nil, max_tries: 1, max_time: nil, delay_epsilon: 0.0001 |
There was a problem hiding this comment.
Just curious why we're not using retry gem for retrying.
Contributor
Author
There was a problem hiding this comment.
Because it's not a simple retry, but one whose conditions and delays are dynamic and tied closely to information from the state of the LazyValue. For example, to determine the delay until the next retry, we need to get the wait time expiration, that is, the next time the computation engine will allow another computation attempt to start.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helper is the core piece of the updated implementation. It provides:
Some of this functionality is similar to that provided by Concurrent::Delay and Concurrent::LazyRegister, but nothing in concurrent-ruby provides everything we need.