Skip to content

Conversation

@pragmaticivan
Copy link
Contributor

fixes #209

  • Updates to latest release please.
  • Updates other packages.

@google-cla google-cla bot added the cla: yes label Feb 10, 2021
@pragmaticivan
Copy link
Contributor Author

Hey @bcoe, so it looks like defaultBranch is actually not available in github-release class as an option for the version this action is using, and it was introduced on https://github.com/googleapis/release-please/releases/tag/v10.0.0 even thought it's not described in the changelog.

So the only way my changes would work would be by having this PR merged.

I can confirm the v10 works via CLI (already tested)

@bcoe
Copy link

bcoe commented Feb 12, 2021

@pragmaticivan thanks for the patch, we've been doing some major refactoring in relese-please, in prep for a couple new features that are coming out soon -- I was dragging my feet a little bit on this update, until we did some QA.

Things have been working okay for us so far, and it sounds like you've tested, so I think it's okay to ship this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use latest release-please (10.1.0)

2 participants