-
Notifications
You must be signed in to change notification settings - Fork 55
feat: create deploy_remote_function
and deploy_udf
functions to immediately deploy functions to BigQuery
#1832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
83d2a7c
Refactor function deployment to avoid code duplication
google-labs-jules[bot] 268b275
Refactor function deployment to use distinct methods
google-labs-jules[bot] 8455c82
Simplify internal deploy_remote_function and deploy_udf calls
google-labs-jules[bot] 6ee5840
Merge remote-tracking branch 'origin/main' into refactor-deploy-immed…
tswast dc59791
add tests and use kwargs
tswast 35d2e6e
add missing func argument to bpd
tswast File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,3 +89,57 @@ def function_without_return_annotation(myparam: int): | |
match="'output_type' was not set .* missing a return type annotation", | ||
): | ||
remote_function_decorator(function_without_return_annotation) | ||
|
||
|
||
def test_deploy_remote_function(): | ||
session = mocks.create_bigquery_session() | ||
|
||
def my_remote_func(x: int) -> int: | ||
return x * 2 | ||
|
||
deployed = session.deploy_remote_function( | ||
my_remote_func, cloud_function_service_account="[email protected]" | ||
) | ||
|
||
# Test that the function would have been deployed somewhere. | ||
assert deployed.bigframes_bigquery_function | ||
|
||
|
||
def test_deploy_remote_function_with_name(): | ||
session = mocks.create_bigquery_session() | ||
|
||
def my_remote_func(x: int) -> int: | ||
return x * 2 | ||
|
||
deployed = session.deploy_remote_function( | ||
my_remote_func, | ||
name="my_custom_name", | ||
cloud_function_service_account="[email protected]", | ||
) | ||
|
||
# Test that the function would have been deployed somewhere. | ||
assert "my_custom_name" in deployed.bigframes_bigquery_function | ||
|
||
|
||
def test_deploy_udf(): | ||
session = mocks.create_bigquery_session() | ||
|
||
def my_remote_func(x: int) -> int: | ||
return x * 2 | ||
|
||
deployed = session.deploy_udf(my_remote_func) | ||
|
||
# Test that the function would have been deployed somewhere. | ||
assert deployed.bigframes_bigquery_function | ||
|
||
|
||
def test_deploy_udf_with_name(): | ||
session = mocks.create_bigquery_session() | ||
|
||
def my_remote_func(x: int) -> int: | ||
return x * 2 | ||
|
||
deployed = session.deploy_udf(my_remote_func, name="my_custom_name") | ||
|
||
# Test that the function would have been deployed somewhere. | ||
assert "my_custom_name" in deployed.bigframes_bigquery_function |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.