Skip to content

test: unflake StatementTimeoutTest #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Mar 18, 2025

The following changes should reduce the flakiness of this test:

  1. Wait for MinSessions to have been created, to prevent interaction with the session pool / multiplexed session creation to interfere with any of the tests.
  2. Force-close all Spanner instances after each test to prevent requests from previous tests to leak into the next test.
  3. Fix the waitForDdlRequestOnServer implementation so it ignores ConcurrentModificationException. These could happen, as the list of requests is not thread-safe (and can also not easily be modified, as it is part of the gapic-generated code).

Fixes #3690
Fixes #3683
Fixes #3368

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Mar 18, 2025
@olavloite olavloite force-pushed the unflake-statement-timeout-test branch from 6958265 to 82690cb Compare March 18, 2025 12:42
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 18, 2025
@olavloite olavloite marked this pull request as ready for review March 18, 2025 13:37
@olavloite olavloite requested review from a team as code owners March 18, 2025 13:37
@olavloite olavloite merged commit 1f285e3 into main Mar 18, 2025
34 of 35 checks passed
@olavloite olavloite deleted the unflake-statement-timeout-test branch March 18, 2025 17:38
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.
Projects
None yet
2 participants