fix(spanner): set gauge metric start time to match end time#14289
Merged
sakthivelmanii merged 1 commit intomainfrom Apr 1, 2026
Merged
fix(spanner): set gauge metric start time to match end time#14289sakthivelmanii merged 1 commit intomainfrom
sakthivelmanii merged 1 commit intomainfrom
Conversation
sakthivelmanii
changed the title
sakthivelmanii
force-pushed
the
fix/grpc-metrics-gauge-aggregation
branch
from
51dbbb8 to
ed415d3
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Spanner metrics configuration to use default aggregation and introduces a new test case, TestBuiltinMetrics_GaugeAggregation, to verify gauge aggregation and attribute filtering. The review feedback suggests improving test stability by replacing a hardcoded sleep with a polling mechanism and removing a redundant manual exporter stop call while ensuring the meter provider shutdown uses a non-cancelable context.
sakthivelmanii
force-pushed
the
fix/grpc-metrics-gauge-aggregation
branch
from
ed415d3 to
2c99011
Compare
This commit fixes an InvalidArgument error ("One or more points were written
more frequently than the maximum sampling period") when exporting gauge metrics
like `open_connections` to Cloud Monitoring.
Previously, the time interval for these gauge metrics started from the moment
the application booted up. This created long, continuously overlapping time
intervals. Cloud Monitoring strictly rejected these because it requires gauges
to be exact, point-in-time measurements, not long durations.
By simply setting the start time equal to the end time (`start = end`), we
correctly format the data as instantaneous point-in-time snapshots. This
satisfies Cloud Monitoring's requirements and allows the metrics to export
successfully on every cycle.
sakthivelmanii
force-pushed
the
fix/grpc-metrics-gauge-aggregation
branch
from
82b5d26 to
9db9693
Compare
sakthivelmanii
changed the title
Contributor
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the toNonemptyTimeIntervalpb function in spanner/metrics_monitoring_exporter.go to set the start time equal to the end time for gauge metrics, ensuring compliance with the Cloud Monitoring API requirements for time intervals. I have no feedback to provide as no review comments were submitted.
rahul2393
approved these changes
Apr 1, 2026
rahul2393
added a commit
that referenced
this pull request
Apr 14, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.10.1 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a <details><summary>spanner: v1.90.0</summary> ## [v1.90.0](spanner/v1.89.0...spanner/v1.90.0) (2026-04-14) ### Features * feat(spanner): add EnableDirectAccess field to ClientConfig (#14287) ([6adf5b7](6adf5b7)) * feat(spanner): Switch to using builtin open telemetry for EEF (#14193)([751febd](751febd)) * feat(spanner): complete location-aware routing resilience and observability (#14418 ) ([77aa4df](77aa4df)) ### Bug Fixes * fix(spanner): set gauge metric start time to match end time (#14289) ([e0760b5](e0760b5)) * fix(spanner): update DirectPath detection logic to use ALTS credentials(#14288)([3cd5716](3cd5716)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an InvalidArgument error ("One or more points were written
more frequently than the maximum sampling period") when exporting gauge metrics
like
open_connectionsto Cloud Monitoring.Previously, the time interval for these gauge metrics started from the moment
the application booted up. This created long, continuously overlapping time
intervals. Cloud Monitoring strictly rejected these because it requires gauges
to be exact, point-in-time measurements, not long durations.
By simply setting the start time equal to the end time (
start = end), wecorrectly format the data as instantaneous point-in-time snapshots. This
satisfies Cloud Monitoring's requirements and allows the metrics to export
successfully on every cycle.