fix: use client opts to auto configure emulator instead of environment variable #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giautm
reviewed
Jul 1, 2025
| if connectorConfig.Host == "" { | ||
| connectorConfig.Host = "localhost:9010" | ||
| } | ||
| schemeRemoved := regexp.MustCompile("^(http://|https://|passthrough:///)").ReplaceAllString(connectorConfig.Host, "") |
There was a problem hiding this comment.
I should like to use url.Parse then update the url scheme instead.
There was a problem hiding this comment.
It was written to be consistent with the client library https://github.com/search?q=repo%3Agoogleapis%2Fgoogle-cloud-go%20%5E(http%3A%2F%2F%7Chttps%3A%2F%2F%7Cpassthrough%3A%2F%2F%2F&type=code
Can you please share any specific test where we need to check scheme from url.Parse instead of just replacing?
There was a problem hiding this comment.
nvm, replacing using url.Parse is more safe with the URL, also handle the case sensitive. But if other places using the same approach, keep it consistent
olavloite
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #459