Skip to content

Testing Issue: breaking changes related to grpc generator #1554

@shollyman

Description

@shollyman

As part of showcase testing in this generator, CI tests effectively compare a recent release of the showcase generated code to one that's output by the generator using apidiff.

The grpc plugin (https://pkg.go.dev/google.golang.org/grpc/cmd/protoc-gen-go-grpc) has a new option (use_generic_streams_experimental) that recently defaulted to true. Because our showcase testing grabs the plugin latest version, we were picking up that new change.

To resolve our immediate issue, we need to add the experimental flag to our build process to disable the newly enabled behavior, and verify what further actions are needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p2Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions