-
Notifications
You must be signed in to change notification settings - Fork 137
[derive] Automatically bless output test output #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the developer experience for maintaining Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable enhancement to the testing workflow by adding a "blessing" mechanism for derive macro output tests. The changes are well-implemented, using an environment variable (ZEROCOPY_BLESS) to toggle between test execution and updating expected output files. The use of prettyplease to normalize both actual and expected outputs is a great practice that makes the tests more robust and less brittle to formatting changes. The related documentation and scripts have been updated accordingly. Overall, this is a solid improvement that will enhance developer productivity and test maintainability.
7b542a6 to
c90cd87
Compare
539552e to
abc3d6f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2905 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5877 5877
=======================================
Hits 5401 5401
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c90cd87 to
92645fe
Compare
abc3d6f to
85454ad
Compare
92645fe to
0b93e1a
Compare
85454ad to
5589919
Compare
Closes #2903 gherrit-pr-id: Gd828ec01c10bd743decbefc4946c3ea5db686237
0b93e1a to
49e1b08
Compare
Closes #2903
Latest Update: v5 — Compare vs v4
📚 Full Patch History
Links show the diff between the row version and the column version.