-
Notifications
You must be signed in to change notification settings - Fork 137
[derive] Refactor into more modules #2901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @joshlf, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a substantial internal refactoring of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a work-in-progress that refactors the zerocopy-derive crate by moving derive logic into a new derive module. This is a great step towards better organization and maintainability. The code has been moved logically into different files under the new module. My main feedback is to improve the naming consistency of the newly created derive functions for better long-term maintenance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2901 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 20 20
Lines 5877 5877
=======================================
Hits 5401 5401
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c97f53b to
f8434d8
Compare
70f0813 to
e903413
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a large but well-executed refactoring of the zerocopy-derive crate. It moves derive logic from lib.rs into a new derive module with a clearer structure, which significantly improves code organization and maintainability. The logic appears to be preserved correctly throughout the move. I've found one issue in the test setup where function paths were not fully updated to reflect the new structure, which will cause test compilation to fail. Overall, this is a great improvement to the codebase.
e903413 to
fa043cb
Compare
fa043cb to
316d9ef
Compare
- Move most top-level derive code into modules under a new top-level `derive` module - Move some utilities into `util` - Leave the root module to primarily perform routing and scaffolding gherrit-pr-id: Gf40a4d73de475b2aae089e5e2d4cea53dd3c868c
316d9ef to
9363bd4
Compare
derivemoduleutilLatest Update: v7 — Compare vs v6
📚 Full Patch History
Links show the diff between the row version and the column version.