Force POSIX '\n' line endings in output on all platforms #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmr
reviewed
Feb 13, 2019
| @@ -25,7 +25,7 @@ def Filename(self): | |||
|
|
|||
| def Write(self): | |||
| filename = os.path.join(self.docdir, self.Filename()) | |||
| with io.open(filename, 'w', encoding='utf-8') as self.file: | |||
| with io.open(filename, 'w', encoding='utf-8', newline='\n') as self.file: | |||
There was a problem hiding this comment.
Might be worth a comment here as to why we're not using the platform-default newline.
There was a problem hiding this comment.
because people may use vimdoc in both window and linux os for same project, if the generation txt file are different, it will cause diff patch when using git.
There was a problem hiding this comment.
Done. Can you check my wording is clear?
There was a problem hiding this comment.
Sure, lgtm. (Probably anything that calls out that we're doing this deliberately is fine.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108.