Open
Conversation
Collaborator
|
There are 3 different Starlark implementations: this one in Go, the Java one built into Bazel, and the Rust one. And my immediate reaction to adding a major feature (a new module) to just the Go implementation would be negative. Is it possible to write something good enough for your use case in pure Starlark and distribute it as a separate package that any Starlark interpreter can use? If it's not possible, what is a minimal set of new interpreter features that you would need in order to be able to write it in pure Starlark? |
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
Signed-off-by: Pierre Fenoll <pierrefenoll@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've just finished porting https://github.com/google/pytruth to Starlark for use in https://github.com/FuzzyMonkeyCo/monkey which requires expressive assertions.
I understand these are the points that should require discussion (some/all are mentioned in the package docs):
Please share your thoughts and take some time to do a bit of reviewing :)