-
Notifications
You must be signed in to change notification settings - Fork 330
Closed
Labels
P1Medium priorityMedium priorityTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling
Description
Feature Description
We are currently running on a roughly older LTS of Node (14) and we should explore updating to the newer LTS (18) to benefit from the performance improvements and npm v7.
This came up while working on #5345 where https://github.com/browserslist/update-db isn't compatible with npm versions < 7.
This issue should include updating the browserslist-update-action to the latest version, see: https://github.com/google/site-kit-wp/pull/5883/files#r1004133133.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
.nvmrcis updated to uselts/jodversion (22.x).- Dependencies that don't support that version are updated to newer versions.
Implementation Brief
- Wait until Move js dependencies required for E2E tests into their own workspace #10013 Move js dependencies required for storybook into their own workspace #10091 Move js dependencies required to build assets into their own workspace #10092 Move js dependencies required for backstop tests into their own workspace #10093 Move js dependencies required for js tests into their own workspace #10094 are merged
- Update the version of Node to
lts/jodin.nvmrc - Do clean install using
npm cicommand and upgrade all dependencies that don't work with the new version - Check all GitHub actions and fix them if any is broken due to version upgrade.
Test Coverage
- N/A
QA Brief
- Plugin should be thoroughly smoke-tested as this adjusts the build process of the plugin.
Changelog entry
- Update version of NodeJS used to build Site Kit.
Metadata
Metadata
Assignees
Labels
P1Medium priorityMedium priorityTeam SIssues for Squad 1Issues for Squad 1Type: InfrastructureEngineering infrastructure & toolingEngineering infrastructure & tooling