-
Notifications
You must be signed in to change notification settings - Fork 333
Closed
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature
Description
Feature Description
Include the AdSense menu item in the updated help menu.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- When the AdSense module is active, the help menu has the additional menu item Get help with AdSense, which matches the Figma design.
- Clicking on the menu item opens the URL https://support.google.com/adsense/ in a new tab.
- The change is gated behind the
setupFlowRefreshfeature flag.
Implementation Brief
This issue follows the same pattern as #11815. Once it has been implemented:
- Export the AdSense help icon from the Figma design and save it to
assets/svg/icons/folder - In
assets/js/components/help/HelpMenu.js:- Import the AdSense help icon
- Add the AdSense help menu item to the
setupFlowRefreshMenuItemsarray using the conditional spread operator pattern (similar to how it's done in themenuItemsarray)- The menu item should only be included when
adSenseModuleActiveistrue - Use the following properties:
href:'https://support.google.com/adsense/'icon: The imported AdSense help icon withwidthandheightset to24children:__( 'Get help with AdSense', 'google-site-kit' )
- Note: Do not set
gaEventLabelfor now, as GA events for the updated menu have not yet been defined. This will be addressed when defining the list of events for this phase of the epic. - Insert this item at the appropriate position in the array to match the Figma design
- The menu item should only be included when
Test Coverage
- Update failing snapshots/VRTs if any
QA Brief
- Set up Site Kit with
setupFlowRefreshenabled - Ensure that the Help dropdown menu does not have an AdSense item
- Activate the AdSense module
- Ensure that the Help dropdown menu has an AdSense item that matches the Figma design
Changelog entry
- Include the AdSense menu item in the updated help menu.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P0High priorityHigh priorityTeam MIssues for Squad 2Issues for Squad 2Type: EnhancementImprovement of an existing featureImprovement of an existing feature