In-progress spinner not appearing in CTA buttons for notices and notifications.

[techanvil]

Bug Description

The in-progress spinner is not appearing in CTA buttons for notices and notifications built using the Banner/CTAButton and Notice/CTAButton components.

Steps to reproduce

Banner/CTAButton example

1. Set up Site Kit on a new site.
2. Click on Set up Ads in the Ads setup banner.
3. See that the in-progress spinner does not appear in the CTA button.

Notice/CTAButton example

1. Connect Analytics and navigate to Settings > Admin Settings.
2. Click on Get tailored metrics in the Key Metrics section.
3. See that the in-progress spinner does not appear in the CTA button.

Screenshots

In-progress spinner not appearing in Set up Ads CTA button:

In-progress spinner not appearing in Get tailored metrics CTA button:

Additional Context

• PHP Version: any
• OS: any
• Browser: any
• Plugin Version: 1.167.0 / 1.154.0
• Device: any

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When following the steps to reproduce, the in-progress spinner should appear in the CTA buttons.

Implementation Brief

• Remove properties with undefined values from restProps in the SpinnerButton component.

Test Coverage

• Add tests for the SpinnerButton component to verify that props with undefined values don't overwrite the props that SpinnerButton explicitly passes to the Button component.

QA Brief

• When running through the steps to reproduce, the in-progress spinner appears in the CTA buttons.

Changelog entry

• Fix in-progress spinner not appearing in CTA buttons for banners and notices.

[nfmohit]

IB ✅

[mohitwp]

QA Update ❌

• Tested on the Dev environment.
• Verified that the loader is now showing for both CTA buttons.

@techanvil

Issue: The loader implemented for the ‘Get Tailored Metrics’ CTA under the Admin Settings is smaller and not consistent with the loaders used for other CTAs.

Details

Recording.2616.mp4