Prevent RRM settings request if it is inactive

[nfmohit]

Bug Description

The Site Kit dashboard makes a fetch request to get the Reader Revenue Manager settings even if the module is not active, which should be avoided.

(Props to @aaemnnosttv for reporting)

Steps to reproduce

1. Go to the Site Kit dashboard with the Reader Revenue Manager module not active.
2. Monitor the network requests.
3. Notice that a GET request to /wp-json/google-site-kit/v1/modules/reader-revenue-manager/data/settings is made.

Screenshots

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

• When the RRM module is inactive, requests to the RRM settings endpoint should not be triggered from the dashboard or any Site Kit screen.

Implementation Brief

• In assets/js/modules/reader-revenue-manager/index.js, update the checkRequirements callback for the following notifications to check if RRM module is active (isModuleActive method), if not active, return false.
  • ProductIDSubscriptionsNotification
  • ProductIDContributionsNotification

Test coverage

• Add the test for this change to ensure settings endpoint is not triggered when RRM module is not active.

QA Brief

• Follow the "Steps to reproduce" above
• Verify that no request to get the RRM settings was made

Changelog entry

• Prevent requests to the Reader Revenue Manager settings endpoint from being triggered when the Reader Revenue Manager module is inactive.

[techanvil]

Hi @ankitrox, thanks for drafting the AC and IB for this issue.

However, the bug description states that the RRM settings endpoint is requested even when the module is not active, whereas the AC & IB only mention the connected state. Please update them accordingly, unless the bug description itself needs an update.

[ankitrox]

Thank you @techanvil for highlighting the difference. I have updated the AC and IB according to the suggestion.

[techanvil]

Thanks @ankitrox! That's great, LGTM.

AC & IB ✅