-
Notifications
You must be signed in to change notification settings - Fork 330
Closed
Labels
Module: AnalyticsGoogle Analytics module related issuesGoogle Analytics module related issuesModule: Search ConsoleSearch Console module related issuesSearch Console module related issuesP1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working
Description
Bug Description
The font size on the Site Kit admin toolbar has been reduced since 1.155.0. We think this is because of the DataBlockGroup changes we introduced in #9419. It looks like the font was 46px previously but is now appearing as 13px.
Site Kit 1.154.0
Site Kit 1.155.0 onwards
Steps to reproduce
- Set up Site Kit with Analytics that has zero data or live data.
- Go to the WordPress admin bar and click on the Google Site Kit logo.
- The toolbar will appear and you'll notice the font size.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The font size within the admin bar data block group should be fixed at 38px.
Implementation Brief
- Update
assets/sass/components/adminbar/_googlesitekit-adminbar.scss- Target
. googlesitekit-subheading-1 googlesitekit-data-block__title .googlesitekit-data-block__title-inner, and addfont-size: inherit- This will ensure
spanis inheriting the parent style which is set to38px
- This will ensure
- Target
Test Coverage
- No updates expected
QA Brief
- Follow steps to reproduce above.
- The text should have the expected font size (first screenshot).
Changelog entry
- Fix a regression that caused the font size of the admin bar data block to appear too small.
Metadata
Metadata
Assignees
Labels
Module: AnalyticsGoogle Analytics module related issuesGoogle Analytics module related issuesModule: Search ConsoleSearch Console module related issuesSearch Console module related issuesP1Medium priorityMedium priorityTeam MIssues for Squad 2Issues for Squad 2Type: BugSomething isn't workingSomething isn't working

