Skip to content

Font size reduced on Site Kit admin toolbar data block #11041

@wpdarren

Description

@wpdarren

Bug Description

The font size on the Site Kit admin toolbar has been reduced since 1.155.0. We think this is because of the DataBlockGroup changes we introduced in #9419. It looks like the font was 46px previously but is now appearing as 13px.

Site Kit 1.154.0

Image

Site Kit 1.155.0 onwards

Image

Steps to reproduce

  1. Set up Site Kit with Analytics that has zero data or live data.
  2. Go to the WordPress admin bar and click on the Google Site Kit logo.
  3. The toolbar will appear and you'll notice the font size.

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • The font size within the admin bar data block group should be fixed at 38px.

Implementation Brief

  • Update assets/sass/components/adminbar/_googlesitekit-adminbar.scss
    • Target . googlesitekit-subheading-1 googlesitekit-data-block__title .googlesitekit-data-block__title-inner, and add font-size: inherit
      • This will ensure span is inheriting the parent style which is set to 38px

Test Coverage

  • No updates expected

QA Brief

  • Follow steps to reproduce above.
  • The text should have the expected font size (first screenshot).

Changelog entry

  • Fix a regression that caused the font size of the admin bar data block to appear too small.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Module: AnalyticsGoogle Analytics module related issuesModule: Search ConsoleSearch Console module related issuesP1Medium priorityTeam MIssues for Squad 2Type: BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions