Consolidate "Permissions Error" during Site Kit Setup

[wpdarren]

Bug Description

I noticed the error banner notification changed when permissions are not given during setting up of Site Kit. Previously the banner had different title, description and included a learn more link which was useful for users.

Conversation on Slack from @zutigrm

This is basically between completely removing the usage of SetupErrorMessageNotification which is shown only on splash screen, we can use SetupErrorNotification here instead, since that notification is used everywhere else and includes learn more link.

Conversation on Slack from @jimmymadon

If possible, we should be using the notification with the Learn more / get help link where it already was appearing before.

Steps to reproduce

1. Create a new test site and Google account (or remove SK in the security area of the Google account you plan to use.)
2. Set up Site Kit and when you are asked to give permissions, do not check any of the checkboxes and click continue.
3. You will be redirected back to the Site Kit dashboard.
4. Observe that there is no learn more link on the banner notification.

Screenshots

How the banner looked previously

How the banner looks now

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• When setting up Site Kit, if all permissions are not granted on the Google oAuth screen, then the "Permissions error" Banner Notification should be shown as before.
  • The Get help link should be included in the URL which should point to this section in the documentation.
  • The Redo the plugin setup button should be displayed that redirects the user back to the oAuth screen to select their google account / accept permissions.

Implementation Brief

• Remove the assets/js/components/notifications/SetupErrorNotification.js component and all its associated stories.
• In assets/js/googlesitekit/notifications/register-defaults.js:
  • Remove the registration of the SetupErrorNotification component.
  • Within the registration of setup_plugin_error notification, add the VIEW_CONTEXT_SPLASH to the list of viewContexts.

Test Coverage

• Migrate the tests from assets/js/components/notifications/SetupErrorNotification.test.js to assets/js/components/notifications/SetupErrorMessageNotification.test.js.

QA Brief

• Reset Site Kit and set it up again, but this time, do not give permissions on the oAuth screen (i.e. follow the "Steps to reproduce"). Verify that the Permissions error shows correctly as per the AC.
• NOTE: The Get help link needs to be updated by @jamesozzie so that it points to the new error banner section.

Changelog entry

• Improve/consolidate permissions errors UI when setting up Site Kit.

[jimmymadon]

@jamesozzie

The https://sitekit.withgoogle.com/support?error_id=access_denied URL should now point to the new Red coloured "Permissions Error" section in our documentation.

I am wondering that we can actually replace the entire https://sitekit.withgoogle.com/documentation/troubleshooting/dashboard/#permissionsnotgranted section with the new section above. The "Error connecting Site Kit" error is actually rare and has the same mitigation steps / documentation as the above section. In fact, the "Permissions error" section contains a little more text which is correct.

Finally, the "Permissions Error" section screenshot needs to be updated after the next release (or you can use develop branch once this issue is merged). The new error will look like in the QA Brief section screenshot.

UPDATE: Heres a handy screenshot with comments:

[jamesozzie]

Noted @jimmymadon. Just a quick question. Your graphics and indicators are excellent above. You mentioned to keep a section and point it to access_denied. That error code already exists in our redirects sheet.

I assume, based on your suggestion, that I'm only changing the link in the redirects sheet that access_denied points to from the existing guide to the guide you suggested?

[jimmymadon]

I assume, based on your suggestion, that I'm only changing the link in the redirects sheet that access_denied points to from the existing guide to the guide you suggested?

Yes, correct!

[tofumatt]

ACs and IB look good; I can see this one has a PR attached so moving it directly to Code Review 🙂