Skip to content

Conversation

@fmayer
Copy link
Contributor

@fmayer fmayer commented Nov 2, 2024

The code is confusing and it is unnecessary

This is confusing and unnecessary
@fmayer fmayer requested a review from vitalybuka November 2, 2024 00:52
@vitalybuka
Copy link
Contributor

This is confusing and unnecessary

Not sure what is this, can you show a diff in HTML?

@fmayer
Copy link
Contributor Author

fmayer commented Nov 2, 2024

This is confusing and unnecessary

Not sure what is this, can you show a diff in HTML?

There is no diff, the code is just confusing because it uses url for both the original URL to query, and then uses the same field to store part of the response.

@fmayer fmayer merged commit a6a191b into google:master Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants