Skip to content

feat: automatically profile when --require'd #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

feat: automatically profile when --require'd #8

merged 1 commit into from
Mar 1, 2019

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Mar 1, 2019

No description provided.

@ofrobots ofrobots mentioned this pull request Mar 1, 2019
Closed
@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 1, 2019

@nolanmar511 How do I get a link to the kokoro build status?

@aalexand
Copy link
Contributor

aalexand commented Mar 1, 2019

@ofrobots http://fusion/dashboard/findbuilds?search_pattern=pprof-nodejs&project_types=&include_inactive_projects=false ?

@ofrobots
Copy link
Contributor Author

ofrobots commented Mar 1, 2019

Normally I see a link right here on the failed/passed status on GitHub, but there wasn't one. Secondly, following the link you pasted, I don't see a build corresponding to my PR.

@nolanmar511
Copy link
Contributor

Yeah -- there aren't "details" links here. I'm still not sure why...

@ofrobots ofrobots requested a review from nolanmar511 March 1, 2019 04:51
@nolanmar511 nolanmar511 merged commit 9043bf3 into google:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanmar511 nolanmar511 nolanmar511 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofrobots @aalexand @nolanmar511