Skip to content

fix: retry npm install in system test when command hangs #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2019
Merged

fix: retry npm install in system test when command hangs #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87c8481
chore: retry npm install in system test when command hangs
nolanmar511 May 22, 2019
0ed0e65
make npm_install work on alpine
nolanmar511 May 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 16 additions & 4 deletions system-test/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,18 @@ retry() {
"${@}" || "${@}" || "${@}" || return 1
}

function timeout_after() {
if [ -f /bin/busybox ]; then
timeout -t "${@}"
else
timeout "${@}"
fi
}

npm_install() {
timeout_after 60 npm install "${@}"
}

set -eox pipefail
cd $(dirname $0)/..

Expand All @@ -16,9 +28,9 @@ NODEDIR=$(dirname $(dirname $(which node)))
# contains unreleased fixes that allow the native component to be compiled
# with Node's V8 canary build.
[ -z $NVM_NODEJS_ORG_MIRROR ] \
|| retry npm install https://github.com/nodejs/nan.git
|| retry npm_install https://github.com/nodejs/nan.git

retry npm install --nodedir="$NODEDIR" \
retry npm_install --nodedir="$NODEDIR" \
${BINARY_HOST:+--pprof_binary_host_mirror=$BINARY_HOST} >/dev/null

npm run compile
Expand All @@ -30,8 +42,8 @@ TESTDIR=$(mktemp -d)
cp -r "$PWD/system-test/busybench" "$TESTDIR"
cd "$TESTDIR/busybench"

retry npm install pify @types/pify typescript gts @types/node >/dev/null
retry npm install --nodedir="$NODEDIR" \
retry npm_install pify @types/pify typescript gts @types/node >/dev/null
retry npm_install --nodedir="$NODEDIR" \
${BINARY_HOST:+--pprof_binary_host_mirror=$BINARY_HOST} \
"$PROFILER">/dev/null

Expand Down