fix: Specify target in tsconfig to fix Node 6 system test #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanmar511
changed the title
kalyanac
changed the title
nolanmar511
changed the title
nolanmar511
changed the title
nolanmar511
changed the title
|
@nolanmar511 Does this force using the target flag value es2015 for all node versions? |
|
Is there a strong reason to continue supporting Node 6? It will reach EOL on Tuesday. |
|
For right now, I think merging just to stop alerts from our continuous tests might make sense. But removing the system tests for Node 6 instead. But yes, this change would cause all versions of Node.js to use the javascript transpiled with the target es2015 -- the npm package only includes 1 version of javascript files and those are used by all versions of Node.js. |
|
ignoring the npmaudit fail for now. |
kalyanac
approved these changes
Apr 26, 2019
|
To make sure, you're planning to remove the es2015 target config at the time you drop support for Node 6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying
targetin the main tsconfig.json was not necessary to make system tests pass, but seemed prudent given the problem we had with the benchmark.