Skip to content

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Apr 4, 2019

Expose API to get V8 heap profile unserialized as well. This can be
useful for clients that want to serialize in a different foramt.

@aalexand
Copy link
Contributor

aalexand commented Apr 4, 2019

@ofrobots node6 and npmaudit tests seem to fail.

Expose API to get V8 heap profile unserialized as well. This can be
useful for clients that want to serialize in a different foramt.
@ofrobots ofrobots force-pushed the export-v8-heap-profile branch from f695b0b to 1c34487 Compare April 10, 2019 16:42
@ofrobots ofrobots requested a review from nolanmar511 April 10, 2019 16:56
@ofrobots
Copy link
Contributor Author

PTAL. The npmaudit failure is expected until mocha dependency is updated to the latest.

@nolanmar511 nolanmar511 merged commit d84558f into google:master Apr 10, 2019
@ofrobots ofrobots deleted the export-v8-heap-profile branch April 10, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants