Skip to content

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Feb 2, 2024

Potentially breaking change as typescript compilation output is not guaranteed to be compatible across major versions.

This combines #285 and #266 together. I fixed a few type errors from the upgrade. Specific versions copied from package.json in cloud-profiler-nodejs downstream

@aabmass aabmass requested a review from a team February 2, 2024 17:14
@aabmass aabmass enabled auto-merge (squash) February 2, 2024 17:14
Copy link
Contributor

@psx95 psx95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little unclear on the details on the breaking changes you mention. But changes look ok.

@aabmass aabmass merged commit fd60e11 into google:main Feb 2, 2024
@aabmass aabmass deleted the upgrade-ts-gts branch February 2, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants