Skip to content

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Jan 31, 2024

Update nvm and the NodeJS version it pulls in.

See the bug for more details. The upgraded NodeJS uses a newer NPM that doesn't complain about when being run as root.

I tested it out by in a local kokoro container and --dry-run flag–the tarball builds correctly:

npm notice                                                                                                                                   
npm notice package: [email protected]                                                                                                              
npm notice === Tarball Contents ===                                                                                                          
npm notice 11.4kB  LICENSE                                                                                                                   
npm notice 4.0kB   README.md                                                                                                                 
npm notice 718B    binding.gyp                                                                                                               
npm notice 15.2kB  bindings/profiler.cc                                                                                                      
npm notice 907B    out/src/heap-profiler-bindings.d.ts                                                                                       
npm notice 1.6kB   out/src/heap-profiler-bindings.js                                                                                         
npm notice 708B    out/src/heap-profiler-bindings.js.map                                                                                     
npm notice 1.6kB   out/src/heap-profiler.d.ts                                                                                                
npm notice 3.4kB   out/src/heap-profiler.js                                                                                                  
npm notice 1.5kB   out/src/heap-profiler.js.map                                                                                              
npm notice 602B    out/src/index.d.ts                                            
npm notice 2.2kB   out/src/index.js                                              
npm notice 899B    out/src/index.js.map                                                                                                      
npm notice 867B    out/src/profile-encoder.d.ts                                  
npm notice 2.1kB   out/src/profile-encoder.js                                                                                                
npm notice 609B    out/src/profile-encoder.js.map                                
npm notice 1.8kB   out/src/profile-serializer.d.ts                                                                                           
npm notice 9.2kB   out/src/profile-serializer.js                                                                                             
npm notice 6.6kB   out/src/profile-serializer.js.map                                                                                         
npm notice 4.0kB   out/src/sourcemapper/sourcemapper.d.ts                                                                                    
npm notice 9.7kB   out/src/sourcemapper/sourcemapper.js                                                                                      
npm notice 3.9kB   out/src/sourcemapper/sourcemapper.js.map                      
npm notice 303B    out/src/time-profiler-bindings.d.ts                                                                                       
npm notice 1.6kB   out/src/time-profiler-bindings.js                                                                                         
npm notice 776B    out/src/time-profiler-bindings.js.map                                                                                     
npm notice 1.6kB   out/src/time-profiler.d.ts                                                                                                
npm notice 3.3kB   out/src/time-profiler.js                                                                                                  
npm notice 1.2kB   out/src/time-profiler.js.map                                                                                              
npm notice 1.3kB   out/src/v8-types.d.ts                                                                                                     
npm notice 731B    out/src/v8-types.js                                                                                                       
npm notice 137B    out/src/v8-types.js.map                                                                                                   
npm notice 1.0kB   out/third_party/cloud-debug-nodejs/src/agent/io/scanner.d.ts                                                              
npm notice 8.3kB   out/third_party/cloud-debug-nodejs/src/agent/io/scanner.js                                                                
npm notice 4.5kB   out/third_party/cloud-debug-nodejs/src/agent/io/scanner.js.map                                                            
npm notice 2.7kB   package.json                                                                                                              
npm notice 40.3kB  proto/profile.d.ts                                                                                                        
npm notice 169.9kB proto/profile.js                                                                                                          
npm notice 121B    proto/README.md                                                                                                           
npm notice === Tarball Details === 
npm notice name:          pprof                                                                                                              
npm notice version:       3.3.0                                                                                                              
npm notice filename:      pprof-3.3.0.tgz                                                                                                    
npm notice package size:  45.7 kB                                                                                                            
npm notice unpacked size: 321.2 kB                                                                                                           
npm notice shasum:        f27f2f45fc7bacca3958ae31a960b21c1310c3a9                                                                           
npm notice integrity:     sha512-w32hA4nFPxwrc[...]hw7AGZS1VOx7g==                                                                           
npm notice total files:   38                                      
npm notice                                                                                                                                   
npm WARN This command requires you to be logged in to https://wombat-dressing-room.appspot.com (dry-run)                                     
npm notice Publishing to https://wombat-dressing-room.appspot.com with tag latest and default access (dry-run

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5bfbea2) 41.94% compared to head (ae0759a) 41.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   41.94%   41.94%           
=======================================
  Files          14       14           
  Lines        2093     2093           
  Branches       42       42           
=======================================
  Hits          878      878           
  Misses       1197     1197           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aabmass aabmass added blocked Progress blocked by another issue kokoro:run and removed blocked Progress blocked by another issue labels Jan 31, 2024
@aabmass aabmass enabled auto-merge (squash) January 31, 2024 05:49
@aabmass aabmass requested a review from a team January 31, 2024 16:12
@aabmass aabmass requested a review from psx95 January 31, 2024 16:33
@aabmass aabmass merged commit da55751 into google:main Jan 31, 2024
@aabmass aabmass deleted the fix-publish branch January 31, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants