Skip to content

chore: modify system test to use Dockerfile files. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

chore: modify system test to use Dockerfile files. #23

merged 1 commit into from
Mar 21, 2019

Conversation

aalexand
Copy link
Contributor

@aalexand aalexand commented Mar 21, 2019 •
edited
Loading

@nolanmar511
Copy link
Contributor

I looked through system test sponge logs (http://sponge/target?id=83dd4d12-9933-44a2-9898-5328b0023252&target=cloud-profiler%2Fpprof-nodejs%2Fsystem-test%2Fpresubmit%2Flinux) for this run. The test passed.

I'll add support for testing binaries download from GCS in a follow-up change.

@nolanmar511 nolanmar511 changed the title Example system test using Dockerfile files. chore: modify system test to use Dockerfile files. Mar 21, 2019
@nolanmar511 nolanmar511 merged commit de0379a into google:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanmar511 nolanmar511 nolanmar511 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aalexand @nolanmar511