Skip to content

chose(dep): update gts to v3 #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 22, 2020
Merged

chose(dep): update gts to v3 #140

merged 6 commits into from
Oct 22, 2020

Conversation

nolanmar511
Copy link
Contributor

No description provided.

@nolanmar511 nolanmar511 changed the title Update gts v3 chose(dep): update gts to v3 Oct 20, 2020
@nolanmar511
Copy link
Contributor Author

System tests should pass when #141 is merged.

macieksmuga
macieksmuga reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@macieksmuga macieksmuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small questions, looks good overall!

macieksmuga
macieksmuga approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@macieksmuga macieksmuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are still failing - if fixing them requires significant changes, ping me.

@nolanmar511 nolanmar511 merged commit 1b83cf4 into google:master Oct 22, 2020
@nolanmar511 nolanmar511 mentioned this pull request Oct 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macieksmuga macieksmuga macieksmuga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nolanmar511 @macieksmuga @kokoro-team