fix: Test with Node 12 on windows, and address compilation errors #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanmar511
force-pushed
the
fix-windows
branch
from
fa57b70 to
98230f3
Compare
nolanmar511
changed the title
kalyanac
reviewed
Feb 12, 2020
nolanmar511
force-pushed
the
fix-windows
branch
from
98230f3 to
8bb65a9
Compare
kalyanac
approved these changes
Feb 12, 2020
kalyanac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling on windows, we got compilation errors with the message "C2131: expression did not evaluate to a constant". This occurred because the compiler used on windows requires that arrays have their size known at compile time. (See here for full details).
The section of the code added to support accurate line numbers (a feature only available with Node 12, so previously only tested on Linux) had declared variable-length arrays. This change switched to using std::vector in places variable length arrays had been used before. With this change, code now compiles on Windows when using Node 12.
This should fix #87.