feat(website): Add search suggestions to OSV database

[dizzydroid]

This PR introduces a new /api/search_suggestions endpoint that aims to provide real-time search suggestions for the OSV vulnerability database.

This PR is part of a larger effort to enhance the search experience across the website (see PR #3657)
Addresses issue #382

[dizzydroid]

dropdown suggestions should now work on the Vulnerability Database page.

[jess-lowe]

This may be due to the merge conflicts but this is what it currently looks like on my end:

[dizzydroid]

I'll resolve the conflicts and look into this, but I have a feeling this could be related to Turbo's cache, did you try a hard reload?

[dizzydroid]

I'm facing the same issue actually but it goes away when I do a hard reload or try in incognito somehow which is strange XD - I will investigate this further and also try to add the dropdown feature to the navbar search too.

[dizzydroid]

I've pushed a fix (hopefully), implemented a few retry mechanisms and fallbacks to ensure the page loads well on the first try. Also restructured the modules by exporting the Search Suggestions class to search.js instead of cluttering index.js. Let me know if this works now - next step should be implementing the dropdown on the navbar's searchbox.

[dizzydroid]

Suggestions are currently working well on the website emulator, both frontend and backend seem to be stable on my end - frontend renders well on first load and backend returns the suggestions array in the response body as expected. Let me know if it works on your end too.

(About the styling, I've went with this change because I didn't like the older one especially the white border because it looked strange in the navbar 😅, I've experimented a few styles and this is the one that looked best but feel free to ask for any specific styling changes!)

[jess-lowe]

Awesome! My small nit would be - would it be possible to show the ids in the search suggestion in uppercase instead of lower? - most vuln IDs present as uppercase :). I'll review the rest of the code when I get the chance!

[another-rex]

Thanks, very nice! Made a bunch of comments.

I do have a question on why the searchSuggestionsManager need to be cleanedup and recreated so much (at least code length wise), is it just because of the "turbo" load?

[dizzydroid]

@another-rex thanks for the review, I'm going through them now and will update! Yes, I've added those retries because of the Turbo cache bug, it seemed that this was the way I got it to stabilize and not load unstyled without needing a forced reload. Weird bug but that seemed to work :)

[dizzydroid]

I've modified the styles, this is how the suggestion dropdowns should look like as of now,

edit: it may not be clearly visible here but the main searchbox (and the navbar's) has a scrollbar when focused on to scroll through suggestions (currently a max of 10 are displayed).

[dizzydroid]

Applied the required linter formatting. The CI check should now pass.

[another-rex]

Looks amazing!

[another-rex]

/gcbrun

[jess-lowe]

LGTM! Great work! We will aim to merge this on Tuesday (Sydney time) after this week's release so we have a week to observe it in the test instance, and make sure the database changes happen smoothly :)

[jess-lowe]

/gcbrun

[jess-lowe]

Ah it looks like the worker tests are failing because of the added search_tags field. Are you able to run make worker-tests locally and see the missing tags? If not I can push a commit with the updated testcases.

[dizzydroid]

Thanks for the heads up, I'll run the tests locally and update you shortly!

[dizzydroid]

@jess-lowe I've updated the test data and the tests are passing for me now. Let me know if this works!

[jess-lowe]

/gcbrun

[another-rex]

It's now live on test.osv.dev! Only some records are showing up as we populate the search_tags.

I did find a bug though, if you scroll down a little bit and try to search, the search dropdown will be offset in the wrong spot. (I think one of the offset calculations in javascript has a sign flipped?)

[dizzydroid]

Awesome, Thanks for the update! Yes it seems like this is happening on both dropdowns, I will look into this and patch it shortly.

[dizzydroid]

Checked the code, calculations look correct, it just didnt account for the relative position of the document.
Should be fixed in #3712