guava android doesn't define module com.google.com

[marinier]

Guava Version

33.4.8-android

Description

I have a library that is used for both desktop and android apps. For this reason I used the android version of guava. In my module-info.java I have had requires com.google.common; for years, and this worked up until 33.4.5-android, when I started getting this build error:

java: module not found: com.google.common

This occurs on every version including 33.4.8-android (the most recent as of this writing). Switching to the jre version fixes the issue. I don't see anything in any of the release notes to indicate this should be broken on the android versions.

Example

<dependency>
                <groupId>com.google.guava</groupId>
                <artifactId>guava</artifactId>
                <version>33.4.8-android</version>
            </dependency>



module org.jsoar.core
{
    requires com.google.common;
    ...
}

Expected Behavior

Compiles.

Actual Behavior

java: module not found: com.google.common

Packages

No response

Platforms

No response

Checklist

• I agree to follow the code of conduct.

• I can reproduce the bug with the latest version of Guava available.

[cpovirk]

Sorry about that. I wasn't sure whether to expect a module-info to be more likely to cause problems for users of guava-android or to solve them. In hindsight, I should have expected this use case to come up.

Oh, I see: We used to have an Automatic-Module-Name for guava-android. But when we removed it from guava-jre, I think I blindly carried that change over to guava-android.

So we might not need to make guava-android a "full" module (though presumably we still should someday). We just need to get back the the half-modularized state that we were in prior to 33.4.5, I hope. If so, this should be pretty easy....

[marinier]

Automatic-Module-Name should be sufficient for my purposes. Thank you!