Add integrations map to Job proto and model

[rfontanarosa]

towards #1537

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces foundational support for job-specific integrations by extending the Job data structure across both the backend (Protocol Buffer definition) and the frontend (TypeScript model and data conversion logic). This change allows for the association of integration-specific configurations directly with a job, paving the way for future feature development related to various integrations.

Highlights

• Protocol Buffer Definition Update: Added an integrations map field to the Job Protocol Buffer message and introduced a new Integration message type.
• TypeScript Model Extension: Extended the Job TypeScript model to include a new integrations property, allowing job-specific integration configurations.
• Data Conversion Logic: Modified the proto-model converters to correctly handle the new integrations field when converting between Protocol Buffer and TypeScript model objects.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• proto/src/ground/v1beta1/job.proto
  • Added map<string, Integration> integrations = 6; to the Job message.
  • Defined a new message Integration {}.
• web/src/app/converters/proto-model-converter.ts
  • Destructured integrations from the job object in jobToDocument.
  • Added logic to convert the integrations map to Pb.Integration objects during proto serialization.
• web/src/app/converters/survey-data-converter.ts
  • Updated jobPbToModel to initialize the integrations map from the protobuf object.
• web/src/app/models/job.model.ts
  • Imported Map from immutable.
  • Defined export type Integration = Record<string, never>;.
  • Added readonly integrations: Map<string, Integration> = Map() to the Job class constructor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully adds an integrations map to the Job proto and its corresponding web models. The changes are consistently applied across the proto definition, data converters, and the model itself. The implementation is solid, and I have one minor suggestion to simplify the code in survey-data-converter.ts.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.94%. Comparing base (3227a7b) to head (2d3a2e4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
web/src/app/converters/proto-model-converter.ts	0.00%	2 Missing ⚠️
web/src/app/converters/survey-data-converter.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2453      +/-   ##
==========================================
- Coverage   58.97%   58.94%   -0.03%     
==========================================
  Files         111      111              
  Lines        2747     2750       +3     
  Branches      408      409       +1     
==========================================
+ Hits         1620     1621       +1     
- Misses       1065     1067       +2     
  Partials       62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.